Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add geospatial property #818

Merged
merged 2 commits into from
Jul 29, 2022
Merged

Add geospatial property #818

merged 2 commits into from
Jul 29, 2022

Conversation

banesullivan
Copy link
Contributor

Work in progress to resolve #805

(using CI to test since I can't get the test env going locally at the moment)

banesullivan and others added 2 commits July 26, 2022 16:45
`getSourceNameFromDict` uses the internal property to prioritize tile
sources.
@manthey manthey force-pushed the patch/geospatial-attr branch from f809ba5 to a026d9e Compare July 26, 2022 21:04
@manthey
Copy link
Member

manthey commented Jul 26, 2022

@banesullivan I pushed a change (and rebased to latest master) to make this work. Change to a non-draft PR and I can approve it.

@banesullivan banesullivan marked this pull request as ready for review July 26, 2022 22:08
@banesullivan
Copy link
Contributor Author

In downstream projects, I have implemented the following to work around this - so this isn't crucial but would be nice to have

https://github.com/girder/django-large-image/blob/43c9ef62d83c4d6f33d3b49cc41f2c678f296584/django_large_image/tilesource.py#L54-L60

@manthey manthey merged commit 4d3ba5e into master Jul 29, 2022
@manthey manthey deleted the patch/geospatial-attr branch July 29, 2022 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not all GDAL sources are geospatial
2 participants